Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22440] Malformed packets in Fast DDS 3 #5466

Merged
merged 2 commits into from
Dec 9, 2024
Merged

[22440] Malformed packets in Fast DDS 3 #5466

merged 2 commits into from
Dec 9, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Dec 5, 2024 •
edited
Loading

Description

New feature NetworkBuffers brings this error. It is caused because boost::send_to with multiple buffers has a maximum buffers. The hardcode value is 64.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #22439. Fix
e809408 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title Malformed packets in Fast DDS 3 [22440] Malformed packets in Fast DDS 3 Dec 5, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 5, 2024
cferreiragonz
cferreiragonz requested changes Dec 5, 2024
View reviewed changes
src/cpp/rtps/messages/RTPSMessageGroup.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/transport/UDPTransportInterface.cpp Outdated Show resolved Hide resolved
@richiware @cferreiragonz
Apply suggestions from code review
0a70d04 
Co-authored-by: Carlos Ferreira González <[email protected]>
cferreiragonz
cferreiragonz approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@cferreiragonz cferreiragonz added this to the v3.2.0 milestone Dec 5, 2024
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.1.x 3.0.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2024 •
edited
Loading

backport 3.1.x 3.0.x

✅ Backports have been created

@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Dec 9, 2024
@richiware richiware merged commit 885878d into master Dec 9, 2024
17 checks passed
@richiware richiware deleted the bugfix/22439 branch December 9, 2024 14:05
mergify bot pushed a commit that referenced this pull request Dec 9, 2024
@richiware @mergify
Fix reach of maximum buffers in asio::send_to (#5466)
b0a5eb5 
* Refs #22439. Fix

Signed-off-by: Ricardo González Moreno <[email protected]>

* Apply suggestions from code review

Co-authored-by: Carlos Ferreira González <[email protected]>

---------

Signed-off-by: Ricardo González Moreno <[email protected]>
Co-authored-by: Carlos Ferreira González <[email protected]>
(cherry picked from commit 885878d)
@mergify mergify bot mentioned this pull request Dec 9, 2024
Merged
11 tasks
mergify bot pushed a commit that referenced this pull request Dec 9, 2024
@richiware @mergify
Fix reach of maximum buffers in asio::send_to (#5466)
18114a6 
* Refs #22439. Fix

Signed-off-by: Ricardo González Moreno <[email protected]>

* Apply suggestions from code review

Co-authored-by: Carlos Ferreira González <[email protected]>

---------

Signed-off-by: Ricardo González Moreno <[email protected]>
Co-authored-by: Carlos Ferreira González <[email protected]>
(cherry picked from commit 885878d)
@mergify mergify bot mentioned this pull request Dec 9, 2024
Open
11 tasks
MiguelCompany pushed a commit that referenced this pull request Dec 11, 2024
@mergify @richiware
Fix reach of maximum buffers in asio::send_to (#5466) (#5471)
08eb543 
* Refs #22439. Fix

Signed-off-by: Ricardo González Moreno <[email protected]>

* Apply suggestions from code review

Co-authored-by: Carlos Ferreira González <[email protected]>

---------

Signed-off-by: Ricardo González Moreno <[email protected]>
Co-authored-by: Carlos Ferreira González <[email protected]>
(cherry picked from commit 885878d)

Co-authored-by: Ricardo González <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @MiguelCompany @cferreiragonz